[file_packager] Remove redundant isNode check
#24884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was added back in emscripten-core#22802 but seems redundant since the check just below for the indexedDB global should be enough to handle the node case. Split out from emscripten-core#24883
sbc100
commented
Aug 8, 2025
| function openDatabase(callback, errback) { | ||
| if (typeof indexedDB == 'undefined') { | ||
| throw 'using IndexedDB to cache data can only be done on a web page or in a web worker'; | ||
| return errback('using IndexedDB to cache data can only be done on a web page or in a web worker'); |
Collaborator
Author
There was a problem hiding this comment.
We do have test coverage for this since without this part of the change the other.test_file_packager_separate_metadata fails under node
kripken
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was added back in #22802 but seems redundant since the check just below for the indexedDB global should be enough to handle the node case.
Split out from #24883